Replies

Laurent Bercotska@treehouse.systems
Sep 23, 2026, 8:32 AM
- using glib
- using strdup
- on an argv element, which will be available for the whole lifetime of the program
- you cannot see it here without the full context, but it loops around n while path is defined outside of the loop, so it needs to free on every iteration or it just overwrites path and leaks
💬 1🔄 0⭐ 3
wicked witch of the unixnavi@social.vlhl.dev
Sep 23, 2026, 8:20 AM
@ska using glib, return SIZE_MAX; /j
💬 0🔄 0⭐ 0
Haelwenn /элвэн/ :triskell:lanodan@queer.hacktivis.me
Sep 23, 2026, 3:37 PM
@navi @ska Also another of glib great rakes: Abort on malloc() failure.
💬 1🔄 0⭐ 0
Laurent Bercotska@treehouse.systems
Sep 23, 2026, 7:04 PM
@lanodan @navi That is far from the worst issue glib has.
💬 0🔄 0⭐ 0
Haelwenn /элвэн/ :triskell:lanodan@queer.hacktivis.me
Sep 23, 2026, 7:07 PM
@ska @navi Yeah, I think one could fill a lengthy HTML page with glib things.

That said for me this one was the first I discovered in glib, and pretty annoying when you hate the OOM-Killer and the mindset that goes with it.
💬 0🔄 0⭐ 0
Laurent Bercotska@treehouse.systems
Sep 23, 2026, 8:40 AM
Let me kill the suspense: it is pkexec https://github.com/polkit-org/polkit/blob/main/src/programs/pkexec.c#L663
The entirety of the polkit code is like this.
"Bro, how many strdups do I need?"
"Yes."
💬 0🔄 0⭐ 3
Laurent Bercotska@treehouse.systems
Sep 23, 2026, 8:44 AM
Does anyone understand how this works at first glance? Isn't a picture supposed to be worth a thousand words? I'd need a thousand words just to describe this picture.
(Transparency unedited. Image straight from the fdo website.)
💬 1🔄 0⭐ 3
Laurent Bercotska@treehouse.systems
Sep 23, 2026, 8:58 AM
I originally just wanted to see how polkit uses PAM, how it interacts with it, check that there isn't some kind of dark voodoo happening since they share some common goals.
What I'm finding is more reasons to stay away from polkit in case you didn't have enough of them.
💬 0🔄 3⭐ 4
Haelwenn /элвэн/ :triskell:lanodan@queer.hacktivis.me
Sep 23, 2026, 3:24 PM
@ska I guess there must be an image editor that's very arcane to use and they accidentally pressed the keys about transparency and shadows, and didn't know where the undo button is.

Or maybe just "graphic design is my passion" gone terribly wrong.
💬 1🔄 0⭐ 0
sarah tonin :wlfBlep:SRAZKVT@tech.lgbt
Sep 23, 2026, 3:39 PM
@lanodan @ska maybe they straight up didn't notice bc image edited on a white background
💬 0🔄 0⭐ 0
Haelwenn /элвэн/ :triskell:lanodan@queer.hacktivis.me
Sep 23, 2026, 3:45 PM
@SRAZKVT @ska Right… reminds me that not all image editors default to showing a checkerboard pattern when there's full transparency going on.
(inkscape most notably, which is specially weird when SVG very much pushes transparency on you, unlike PNG/JPEG/…)
💬 0🔄 0⭐ 0
David Chisnall (*Now with 50% more sarcasm!*)david_chisnall@infosec.exchange
Sep 23, 2026, 9:59 AM
@ska
The argv array is mutable, so there's an argument for defensive copies if something else in the program might mutate them. But that just raises even more questions.
💬 0🔄 0⭐ 2
Laurent Bercotska@treehouse.systems
Sep 23, 2026, 11:41 AM
@david_chisnall Indeed, I always tend to forget that argv is mutable, because mutating it is another code smell 😅
💬 0🔄 0⭐ 2
Haelwenn /элвэн/ :triskell:lanodan@queer.hacktivis.me
Sep 23, 2026, 3:35 PM
@ska @david_chisnall Plus well, even with argv being mutable, it's not something that libraries can modify sneakily since you need to pass it as pointer to function calls for them to do so.

(Not that this concern should ever exists in security-critical programs, but it's polkit where even the list of dependencies is a smell)
💬 0🔄 0⭐ 0