Login
You're viewing the scottodon.com public feed.
  • Mar 18, 2026, 11:18 PM

    one of the more useful things I realized at some point for how to be a good code reviewer is "that's not how I'd do it" is not constructive feedback and is not a valid reason to request a change, and if you can't think of an actual good reason to block a review, you can save a lot of time for everybody involved by just chilling out about it

    💬 2🔄 59⭐ 125

Replies

  • 💬 1🔄 48⭐ 125
  • Mar 18, 2026, 11:23 PM

    side thought: I don't get people who are adverse to reading code written by other people. how on earth did you people learn to program?

    💬 0🔄 5⭐ 38
  • Mar 19, 2026, 1:59 PM

    @aeva at my previous job, we did a lot of "this is absolutely valid but check out this new [insert language] feature!" Or "I'm not familiar with this, can you explain more or write some comments?" It was SUPER rare any of us said "no not like that".

    💬 0🔄 0⭐ 0