diffed against master (045958ac at time of me subjecting myself to this)... well, it was a pain to read (with `delta` as pager)
and it really did seem to just ... throw/collapse a bunch of logic
on the whole, impression: if the prompt didn't exist || if we were 6~8y in the past, linus himself probably would've shouted this branch into rejection
kernel/C devs who want to tell me I'm hilariously wrong, go right ahead but please bring detail
and, like, I'm not gonna fight you. I don't give a fuck about a kernel holy war.
I'm coming at this from "I've had to hack some C (for various reasons, in various software)" over the years, and this patch looks like a fucking mess to me. even in _other_ languages this patch would look like a fucking mess, imo
@froztbyte Failure is an important part of progress, learning and iteration of processes.
😂
@froztbyte The correct merge-base is not 045958ac or master, it's v7.3-rc7 (24a19b95). You should diff against the merge-base, or you'll have hundreds of unrelated commits mixed in.