Login
You're viewing the functional.cafe public feed.

Replies

  • Oct 15, 2026, 4:33 PM

    @craftyguy Generally, yes. But I think it's reasonable to ask for minor changes as part of review. Keeping the codebase clean and consistent is part of keeping it approachable.

    What you don't want to do is get a new contributor stuck in the middle of a nitpick fight between maintainers. Conflicting code review comments, especially over tiny things, is a good way to get a new contributor to run away scared.

    @neal

    💬 1🔄 1⭐ 0
  • Oct 15, 2026, 4:51 PM

    @gfxstrand @neal oh ya, I definitely meant the second half of your comment, not the first. Sorry for being too concise, and nice job summarizing it 😅

    💬 1🔄 0⭐ 0
  • Oct 15, 2026, 4:57 PM

    @craftyguy @neal No worries! Being concise is good.

    And this is something I genuinely struggle with, especially when one of the reviewers is also a newbie. I want new people to get involved in review! And often other new people’s patches make for easy, approachable reviews. But then sometimes the new reviewer is wrong and what they saw in one part of the project is not actually how we do things in general but I don’t want the even newer contributor to feel caught in a maintainer fight and… Gah! Community building is hard. 😅

    💬 0🔄 0⭐ 0