@GabrielKerneis @leaverou In a case like this it might make sense for the PR to become the next major release?
I don't maintain anything public (not because of this, but in part because I've seen things like this at places I've worked) so I'm betting there are consequences for having a rewrite on either side of a support horizon
@EndlessMason @GabrielKerneis FWIW, I've been doing open source for 14+ years and the good far outweighs the bad. You just hear about the bad more frequently, because people are more likely to post to vent than to post "People are wonderful, someone just sent me a PR to add a whole testsuite to my project"
@leaverou @GabrielKerneis I am sure a lot of them are.
I do often find myself paired with someone who half-jokingly suggests following the "fix it later" methodology, only to gleefully plow ahead when I point out that submitting a PR with tests and adding a temp work around to the app is both less work short term and less cursed long term
You know, the old "oh, why do we depend-exact-version on a version of libxxx from 1997?" or "Is this just the whole of X::Y pasted in here"?