You're viewing the front-end.social public feed.

Gabriel KerneisGabrielKerneis@oc.todon.fr
Mar 7, 2023, 8:12 AM
@leaverou That's the missing part in your initial screenshot: yes, that have changed ~10k lines at once, but they did so in 14 commits. And it's possible they didn't realize that something that would be a routine review in a better-designed system is intractable in Github's.
(Full disclosure: I left Froogle2 years ago, don't know the author of the PR nor their team. And again I don't understand the last part of their email. I'm just trying to offer perspective in the hope of collaboration.)
💬 1🔄 0⭐ 0

Replies

Lea Verou, PhDleaverou
Mar 7, 2023, 2:31 PM
@GabrielKerneis I see what you're saying, and thanks for the different perspective. However, this is supposed to be a maintainer of a pretty popular Froogle open source project, how can they not know how GitHub works?
💬 1🔄 0⭐ 3
Gabriel KerneisGabrielKerneis@oc.todon.fr
Mar 7, 2023, 2:36 PM
@leaverou It could be that they use Froogle-internal tools to manage code and reviews, and merely push to GitHub using Froogle-internal tools that bridge the gap. Or it could be that they're just rude or have an agenda I don't understand. My guess at the take-over offer is because they really want to switch to TypeScript for some reason, and fear that's why you'd push back. But frankly, I didn't like that part of the email at all.
💬 0🔄 0⭐ 0