
- Michael LynchmichaelApr 30, 2022, 2:01 PM
Replies
- Michael LynchmichaelApr 30, 2022, 2:01 PM
I still didn't love the idea of storing the redundant file size, and I considered alternatively creating a virtual SQLite table.
But we'd still have to populate the virtual table still at app load time, which would take ~10s per GB of data
https://www.sqlite.org/vtab.html - Michael LynchmichaelApr 30, 2022, 2:01 PM
- Michael LynchmichaelApr 30, 2022, 2:01 PM
Hope you enjoyed following along! Here's the full PR with the fix: https://github.com/mtlynch/picoshare/pull/221
- Michael LynchmichaelMay 1, 2022, 12:36 AM
- Michael LynchmichaelMay 1, 2022, 1:30 AM
Creating the index is a one-line fix, and it doesn't have the drawback my original PR did of storing a redundant copy of the file size. https://github.com/mtlynch/picoshare/pull/230/files